feat: redshift data driver #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atzoum
commented
Mar 14, 2024
| @@ -8,9 +8,9 @@ | |||
| "_integer": 1, | |||
| "_smallint": 1, | |||
| "_bigint": 1, | |||
| "_real": 1.1, | |||
There was a problem hiding this comment.
Note: redshift-data driver returns some imprecise value, e.g. 1.10000000034
atzoum
commented
Mar 14, 2024
| "_float": 1.1, | ||
| "_float4": 1.1, | ||
| "_float4": 1, |
There was a problem hiding this comment.
Note: redshift-data driver returns some imprecise value, e.g. 1.10000000034
atzoum
commented
Mar 14, 2024
| @@ -44,6 +44,10 @@ func jsonRowMapper(databaseTypeName string, value any) any { | |||
| if n, err := strconv.ParseFloat(string(v), 64); err == nil { | |||
| return n | |||
| } | |||
| case string: | |||
There was a problem hiding this comment.
Note: redshift-data driver returns NUMERIC data types as string instead of []byte
atzoum
commented
Mar 14, 2024
| dest[i] = nil | ||
| case *types.FieldMemberStringValue: | ||
| switch { | ||
| case strings.EqualFold(*rows.page.ColumnMetadata[i].TypeName, "timestamp"): |
There was a problem hiding this comment.
Note: to be compatible with the behaviour of pg driver, we need to:
- Parse the string into a time
- Convert the time to UTC and parse it as an RFC3339 string.
atzoum
force-pushed
the
feat.redshiftDriver
branch
from
029e9d3 to
606462d
Compare
atzoum
force-pushed
the
feat.redshiftDriver
branch
4 times, most recently
from
c4a38b3 to
b6f691a
Compare
atzoum
requested review from
AchuthaSourabhC,
RanjeetMishra,
vyeshwanth,
ruchiramoitra and
Vikas26021999
atzoum
force-pushed
the
feat.redshiftDriver
branch
5 times, most recently
from
d0b611e to
2073245
Compare
atzoum
force-pushed
the
feat.redshiftDriver
branch
from
2073245 to
63020ec
Compare
atzoum
force-pushed
the
feat.redshiftDriver
branch
from
63020ec to
1eadb3e
Compare
atzoum
force-pushed
the
feat.redshiftDriver
branch
3 times, most recently
from
307c3e5 to
a878fda
Compare
atzoum
force-pushed
the
feat.redshiftDriver
branch
from
a878fda to
92b401f
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Including the option to use an alternative sql driver for redshift, based on the Redshift Data API Service.
Credentials example for using the new
redshift-datadriver:{ "type": "redshift-data", <-- type qualifier "clusterIdentifier": "clusterIdentifier", "database": "database", "user": "user", "region": "region", "sharedConfigProfile": "sharedConfigProfile" }Credentials example for using the original
postgresdriver:{ "host": "host", "port": 5432, "dbname": "dbname", "user": "user", "password": "password", "sslmode": "sslmode" }The
sqlconnect.DBinterface's behaviour remains the same regardless which driver is being used, in terms of:However, differences shall be expected by clients in the following:
ExecContextoperations are allowed in the context of an ongoing transaction, notQueryContext.Security